fix(dbt): dbt test description extract #19464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
rexledesma
force-pushed
the
fix-dbt-test-description
branch
from
ea8b893
to
eaa6920
Compare
|
Thanks for the contribution! I've added tests to this and hoping to merge this soon. |
rexledesma
reviewed
Jan 30, 2024
| @@ -246,7 +235,7 @@ def my_dbt_assets(context: AssetExecutionContext, dbt: DbtCliResource): | |||
| def test_materialize_no_selection(dbt_commands: List[List[str]]) -> None: | |||
| result = _materialize_dbt_assets(dbt_commands, selection=None, raise_on_error=False) | |||
| assert not result.success # fail_tests_model fails | |||
| assert len(result.get_asset_materialization_events()) == 9 | |||
There was a problem hiding this comment.
This seemed wrong to begin with, since there are 10 expected materializations (4 seeds + 6 models). Updating the manifest resulted in this error, so fixing it.
johannkm
approved these changes
Jan 31, 2024
OwenKephart
pushed a commit
that referenced
this pull request
Jan 31, 2024
## Summary & Motivation According to the problem [Adding descriptions to tests is no longer possible from 0.20.0](dbt-labs/dbt-core#3599 ) and the source code [SchemaGenericTestParser](https://github.com/dbt-labs/dbt-core/blob/main/core/dbt/parser/schema_generic_tests.py#L39) the general test does not support the description in the schema. This fix allows users to define a test description in `tests/<generic test>/config/meta/description`, to display data in Dagster(UI) Asset Check. ```yaml models: - name: wildberries_incomes tests: - name: 'Equal_row_count_with_stg__wildberries_incomes' config: meta: description: "Equal rows before join with mapping table" test_name: equal_rowcount compare_model: source('production', 'stg__wildberries_incomes') compare_model_final: True ``` Related: dbt-labs/dbt-core#2578  ## How I Tested These Changes pytest Co-authored-by: Rex Ledesma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
According to the problem Adding descriptions to tests is no longer possible from 0.20.0 and the source code SchemaGenericTestParser the general test does not support the description in the schema.
This fix allows users to define a test description in
tests/<generic test>/config/meta/description, to display data in Dagster(UI) Asset Check.Related: dbt-labs/dbt-core#2578
How I Tested These Changes
pytest