-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(dbt): dbt test description extract (#19464)
## Summary & Motivation According to the problem [Adding descriptions to tests is no longer possible from 0.20.0](dbt-labs/dbt-core#3599 ) and the source code [SchemaGenericTestParser](https://github.com/dbt-labs/dbt-core/blob/main/core/dbt/parser/schema_generic_tests.py#L39) the general test does not support the description in the schema. This fix allows users to define a test description in `tests/<generic test>/config/meta/description`, to display data in Dagster(UI) Asset Check. ```yaml models: - name: wildberries_incomes tests: - name: 'Equal_row_count_with_stg__wildberries_incomes' config: meta: description: "Equal rows before join with mapping table" test_name: equal_rowcount compare_model: source('production', 'stg__wildberries_incomes') compare_model_final: True ``` Related: dbt-labs/dbt-core#2578 ![Снимок экрана 2024-01-29 в 14 57 45](https://github.com/dagster-io/dagster/assets/34104577/2638a04c-935f-4368-b21b-04c5de740614) ## How I Tested These Changes pytest Co-authored-by: Rex Ledesma <[email protected]>
- Loading branch information
1 parent
0ec6fe5
commit 5c13175
Showing
4 changed files
with
18 additions
and
29 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...raries/dagster-dbt/dagster_dbt_tests/dbt_projects/test_dagster_asset_checks/manifest.json
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters