-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Clear Control dataset support #114
Conversation
Thanks @ziw-liu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me! @JoOkuma you can decide whether the other 'public' functions in the module need to be in the documentation.
Didn't test this on any actual data though, but I trust your judgement on when to merge.
I'm not sure why Sphinx didn't document them automatically, maybe because there're properties (getters). I merged with main. I added ClearControl first on the documentation to keep it sorted alphabetically, but the list was not fully sorted, let me know if you prefer a different ordering. |
The current ordering is manual, listing the 'primary entry points' on the top. I think it may make sense to move all the one-microscope-specific formats (Dorado, PTI etc.) to a secondary node. But maybe we can deal with that in #112? |
This PR implements the Clear Control dataset reader.
Besides a basic working functionality, the CC reader class provides the expected attributes of an array and a least recently used cache, so it just works with napari, and no zarr or dask is needed.
For example:
NOTE: it's loaded just as an array, so there is no scaling according to metadata or splitting the channels into layers.
cc-dataset-demo.mp4