Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat pims multi channels colors #104

Closed
wants to merge 49 commits into from
Closed

Feat pims multi channels colors #104

wants to merge 49 commits into from

Conversation

urubens
Copy link
Contributor

@urubens urubens commented Jun 2, 2022

No description provided.

urubens added 30 commits May 13, 2022 10:05
@urubens
feat: Use webp thumbnails
1824439
@urubens
fix: Change tile urls
522d773
@urubens
fix: Do not display unavailable image filters
d945e7e
@urubens
fix: annotation drawing with no outline with pims
a8f9cb6
@urubens
fix: Find vendor from format instead of mime
1464e3c
@urubens
feat: Add new uploaded file status (to be moved to JS client)
44c1479
@urubens
Fix: tile parameter for inverse colormap, filter and intensities
614c76a
@urubens
feat: Add tile parameters for z-slice and timepoint
3de8e2b
@urubens
feat: Extract thumbnail display into component [REQUIRES JS CLIENT WI…
8a8ad27 
…TH easy-thumb-url feature]
@urubens
fix: Improve thumb/crop URL building when used as background image
643e4e4
@urubens
Support extra parameters for image thumb url
529a05f
@urubens
Fix thumb url when no extra parameters
0177bc6
@urubens
feat: Show dynamic list of supported formats from backend image servers
03e707b
@urubens
fix: Update attributes of ImageInstance/AbstractImage:extrinsicChanne…
5ede248 
…ls -> apparentChannels
@urubens
fix: mess with channels and apparentChannels
ba494e2
@urubens
feat: Add nb of concrete channels and nb of samples in image details
61c177b
@urubens
fix: slow thumbnail in image selector + improve detection of best ima…
f12ebb4 
…ge format (webp/jpg) for thumbs
@urubens
Extract image controls shift buttons to a component
4bdf629 
(cherry picked from commit 5930aa9)
@urubens
feat: Add step selector in image controls
ba9c9e4 
(cherry picked from commit 01058ae)
@urubens
Simplify image controls buttons
c6f6f8b 
(cherry picked from commit 38881dd)
@urubens
refactor: Each image dimension has its own step value in image controls
ddb10e4 
(cherry picked from commit 09e896e)
@urubens
chore: update license year for controls.js
18fdd63
@urubens
Add support for non-standard tile size
3d8f939 
(cherry picked from commit 4a4bb10)
@urubens
Clean tile URL building in viewer
a801586
@urubens
feat: Allow to have multiple active slices at same time in a viewer. …
46decba 
…Only works for multiple channels having same (Z,T) coordinates.

Best option to allow visualisation of merged channels until a true annotation multi-slice support
@urubens
feat: Disable draw when multiple slices (channels) are displayed
8f187c3
@urubens
feat: Show annotation channel name in current selection if multiple c…
e632dd4 
…hannels are displayed in viewer
@urubens
Merge branch 'uliege-refactor-image-controls' into uliege-feat-pims-m…
5193ff9 
…ulti-channels

# Conflicts:
#	src/components/viewer/ImageControls.vue
#	src/locales/translations.csv
@urubens
Speed up fetchSliceInstancesAround for images with many slices
5a18f07
@urubens
refactor: Comment old color manipulation methods
08c41ff
urubens added 19 commits May 20, 2022 14:36
@urubens
refactor: Start rewrite Color Manipulation panel: allow to show/hide …
1532c24 
…& change color of a channel on-the-fly.
@urubens
feat: Color manipulation: adjustable LUT + auto adjust + reset
ef7e9fb
@urubens
Color manipulation: channel name is clickable (and toggles histogram)
ad3b740
@urubens
fix: histogram background color update
6202963
@urubens
Clean histogram chart
ff9670f
@urubens
histogram chart: remove highest value
f2f5b8b
@urubens
Improve color manipulation adjust/reset button UX
de03bf0
@urubens
color manipulation: disable adjust/reset button in per-channel adjust…
15872e9 
…able LUT
@urubens
Debounce color selector for channel color manipulation
cb42ee6
@urubens
feat: Synchronize channel image controls select with merged channels …
b55bc39 
…+ rename some variables with 'Index' to avoid confusion between objects and ids
@urubens
Re-use max mergeable channels with new color manipulation panel, a li…
9e8ef2c 
…ttle bit still experimental as we should validate this on very large set of channels
@urubens
Fix sorting of channels thanks to the beauty of JS
5dddee7
@urubens
Fix selection of "mergd-channels" in image controls
25b8e70
@urubens
Color manipulation: add settings dropdown with histogram scale param
ee95a90
@urubens
Color manipulation: add setting to choose adjustment of intensities: …
a235abe 
…by min/max or by brightness/contrast
@urubens
Color manipulation: do not show filter selector if there is none
3ffd308
@urubens
Fix watchers for brightness/contrast computation
a10b9f6
@urubens
feat: set default max mergeable channels to 36
0d7fd01
@urubens
fix: color manipulation panel display when more than one image in a v…
c32d352 
…iewer

Signed-off-by: Ulysse Rubens <[email protected]>

(cherry picked from commit 87f4eb6)
@geektortoise
Copy link
Contributor

geektortoise commented Jun 2, 2022 •
edited
Loading

After #103 and #109

@waliens
Copy link
Contributor

waliens commented Jun 29, 2023

Already merged

@waliens waliens closed this Jun 29, 2023
@bathienle bathienle deleted the feat-pims-multi-channels-colors branch June 30, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
V 4.1 Cytomine Community Edition
Development

Successfully merging this pull request may close these issues.
3 participants
@urubens @geektortoise @waliens