Closed
Conversation
Contributor
|
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
1 task
Member
|
Thanks for reopening - although this PR is now converting the files to JS without the decaffeinated fixes, and causing conflicts. You'll need to pull down develop - which now has #5556 merged in and work off from there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User facing changelog
Formats number strings in test results in quotes. In other words, 25 -> '25'.
Additional details
Why was this change necessary:
What is affected by this change?
Not much. I added a test to show this case clearly.
Any implementation details to explain?
Not much. Just fixed some regexes.
NOTE: As it is based on decaffeination of #5556, it should be merged after that PR. When that PR is merges, I'll force-push this branch again without decaffeination.
How has the user experience changed?
Before: above.
After 1 in #5543:

After 2:

PR Tasks
Has a PR for user-facing changes been opened incypress-documentation?Have API changes been updated in thetype definitions?Have new configuration options been added to thecypress.schema.json?