Decaffeinate chai.coffee and assertions_spec.coffee.#5556
Merged
jennifer-shehane merged 8 commits intocypress-io:developfrom Nov 6, 2019
Merged
Decaffeinate chai.coffee and assertions_spec.coffee.#5556jennifer-shehane merged 8 commits intocypress-io:developfrom
jennifer-shehane merged 8 commits intocypress-io:developfrom
Conversation
Contributor
|
Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.
PR Review ChecklistIf any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'. User Experience
Functionality
Maintainability
Quality
Internal
|
This was referenced Oct 31, 2019
Closed
jennifer-shehane
approved these changes
Nov 6, 2019
Member
jennifer-shehane
left a comment
There was a problem hiding this comment.
Thanks for the giant text to not squash. I've been saying we need our cypress bot to comment on PRs that have the decaffeinate: in a commit to say not to squash, but...manually handled today.
Contributor
|
Released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparation for #25.
NEVER SQUASH THIS COMMIT.