Skip to content

Conversation

@sebinsua
Copy link
Contributor

@sebinsua sebinsua commented Oct 7, 2019

Documention for the PR to add padding to element screenshots.

See: cypress-io/cypress#5078

jennifer-shehane and others added 16 commits September 5, 2019 11:16
* add instrument-cra plugin link

* add another cy.within example

* Fix typo

* lowercase 'TR'


Co-authored-by: Jennifer Shehane <[email protected]>
Develop

Co-authored-by: Gleb Bahmutov <[email protected]>
Co-authored-by: Quinton Aiken <[email protected]>
Co-authored-by: Anton Synenko <[email protected]>
Co-authored-by: 洋洋 <[email protected]>
Co-authored-by: null <29139614+renovate[bot]@users.noreply.github.com>
Develop

Co-authored-by: Gleb Bahmutov <[email protected]>
Co-authored-by: Bruno Pulis <[email protected]>
Develop

Co-authored-by: Justin Searls <[email protected]>
Co-authored-by: Anton Synenko <[email protected]>
Co-authored-by: null <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Shawn Taylor <[email protected]>
Develop

Co-authored-by: Alexey Prinkov <[email protected]>
Co-authored-by: null <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Oak Cooper <[email protected]>
Develop

Co-authored-by: null <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Oleksandr Shevtsov <[email protected]>
Co-authored-by: Gleb Bahmutov <[email protected]>
* add note about potential IDE TS server issues

* include js in file types that support restart command
@CLAassistant
Copy link

CLAassistant commented Oct 7, 2019

CLA assistant check
All committers have signed the CLA.

@sebinsua sebinsua force-pushed the feat/add-padding-support-to-element-screenshot-4440 branch from 855b651 to ad98a68 Compare October 9, 2019 15:57
@sebinsua
Copy link
Contributor Author

sebinsua commented Oct 9, 2019

@chrisbreiding I've made the change you requested.

@jennifer-shehane jennifer-shehane changed the base branch from develop to 3.5.0-release-changes October 9, 2019 19:11
@jennifer-shehane jennifer-shehane merged commit ac3b9b0 into cypress-io:3.5.0-release-changes Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants