-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add padding support to element screenshot #2139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jennifer-shehane
merged 17 commits into
cypress-io:3.5.0-release-changes
from
sebinsua:feat/add-padding-support-to-element-screenshot-4440
Oct 11, 2019
Merged
Add padding support to element screenshot #2139
jennifer-shehane
merged 17 commits into
cypress-io:3.5.0-release-changes
from
sebinsua:feat/add-padding-support-to-element-screenshot-4440
Oct 11, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Develop
* add instrument-cra plugin link * add another cy.within example * Fix typo * lowercase 'TR' Co-authored-by: Jennifer Shehane <[email protected]>
Develop Co-authored-by: Gleb Bahmutov <[email protected]> Co-authored-by: Quinton Aiken <[email protected]> Co-authored-by: Anton Synenko <[email protected]> Co-authored-by: 洋洋 <[email protected]> Co-authored-by: null <29139614+renovate[bot]@users.noreply.github.com>
Develop Co-authored-by: Gleb Bahmutov <[email protected]> Co-authored-by: Bruno Pulis <[email protected]>
Develop Co-authored-by: Justin Searls <[email protected]> Co-authored-by: Anton Synenko <[email protected]> Co-authored-by: null <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Shawn Taylor <[email protected]>
Develop Co-authored-by: Alexey Prinkov <[email protected]> Co-authored-by: null <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Oak Cooper <[email protected]>
Develop
Develop Co-authored-by: null <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Oleksandr Shevtsov <[email protected]> Co-authored-by: Gleb Bahmutov <[email protected]>
Release-1: 09-26-2019
@amirrustam @jennifer-shehane Add supplementary videos to relevant doc articles
Co-authored-by: Kevin Old <[email protected]>
* add note about potential IDE TS server issues * include js in file types that support restart command
5 tasks
chrisbreiding
requested changes
Oct 9, 2019
855b651 to
ad98a68
Compare
Contributor
Author
|
@chrisbreiding I've made the change you requested. |
chrisbreiding
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documention for the PR to add
paddingto element screenshots.See: cypress-io/cypress#5078