Skip to content

Release-1: 09-26-2019 #2105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jennifer-shehane merged 4 commits into from
Sep 27, 2019
Merged

Release-1: 09-26-2019 #2105

jennifer-shehane merged 4 commits into from
Sep 27, 2019

Conversation

@amirrustam
Copy link
Contributor

@amirrustam amirrustam commented Sep 26, 2019

  • Grammar fixes
  • Typo on cy.its docs
  • Top banner fixes and updates

brettz9 and others added 4 commits September 24, 2019 17:13
@brettz9 @jennifer-shehane
Grammar nits (#2096)
63a0373 
-- Join independent clauses with semi-colon instead of comma
-- "find value out of" -> "find value in" (or could be "get value out of")
-- "js-dom" -> "jsdom"
-- misc.
@fritz-c @jennifer-shehane
Fix typo in cy.its documentation (#2100)
83abacf
@TonySynenko @amirrustam
change banner content_type from topBanner to docsTopBanner (#2068)
3f19e92
@TonySynenko @amirrustam
Revert "issue 2071 (#2072)" (#2103)
3584112 
This reverts commit 74f501c.
@jennifer-shehane jennifer-shehane merged commit 61f7456 into master Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jennifer-shehane jennifer-shehane jennifer-shehane approved these changes

@bahmutov bahmutov Awaiting requested review from bahmutov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@amirrustam @jennifer-shehane @brettz9 @fritz-c @TonySynenko