Revert "issue 2071" #2103
Merged
Revert "issue 2071" #2103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 74f501c.
amirrustam
approved these changes
Sep 26, 2019
Contributor
|
@TonySynenko and @KateAbramova I understand the change here, but can you articulate why this change needs to be made before we merge in? |
|
This logic doesn't work right for dev, there have to be different keys for stage environment. That will be done later and PR will be made with appropriate changes. |
Contributor
|
@KateAbramova, ok merging in now since the content in staging is irrelevant. Please create dedicated issue for the fix and link me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #2072
Needs to be re-worked due to the latest changes