Optimize Thought and Toolbar components #499
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #484
It was observed that on every cursor move (up and down) the toolbar was gratuitously re-rendered, which caused performance overheads. After moving the cursor-dependent logic to mapStateToProps, the rendering time was reduced by ~20% (for revisited thoughts)
All the thoughts were re-rendered because of similar computations placed inside
Thought.js
. Since theconnect
function implicitly wraps components inside a 'memo', the values that were previously calculated in the component could be pre-computed and passed down as props, resulting in another significant reduction in rendering time(~30%)On average, the rerender time has been reduced to ~50% (reports attached)
profiling_data.zip
If the logic is moved to selectors it'd result in better readability, separation of concerns, and possibly, further optimization(if we use reselect/custom memoizing functions).