Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize cursor movement #484

Closed
raineorshine opened this issue Mar 29, 2020 · 1 comment
Closed

Optimize cursor movement #484

raineorshine opened this issue Mar 29, 2020 · 1 comment
Labels
hold Pause development performance Improve performance
Milestone
⚡️ 100k Thoughts

Comments

@raineorshine
Copy link
Contributor

From #421 (comment):

FYI, performance is at least no worse than the existing implementation. Tested with ~10k thoughts. They're both bad. Looking forward to optimizing in a separate task.

dev:
cursorUp: 260ms
cursorDown: 802ms
cursupUp: 312ms
cursorDown: 706ms
cursorUp: 280ms
cursorDown: 825ms
cursupUp: 247ms
cursorDown: 730ms
cursupUp: 344ms

restore-selection (PR)
cursorUp: 250ms
cursorDown: 500ms
cursupUp: 352ms
cursorDown: 521ms
cursorUp: 750ms
cursorDown: 200ms + 200ms (keyup and keydown)
cursupUp: 600ms
cursorDown: 223ms + 165ms (keyup and keydown)
cursupUp: 522ms

I have not yet measured how much is the result of business logic and how much is rendering. #188 is the first major step towards render optimization.
@raineorshine raineorshine added the performance Improve performance label Mar 29, 2020
@raineorshine raineorshine changed the title Optimize cursorUp, cursorDown, cursorNext, cursorPrev Optimize cursorUp, cursorDown, cursorNext, cursorPrev Mar 29, 2020
@raineorshine raineorshine changed the title Optimize cursorUp, cursorDown, cursorNext, cursorPrev Optimize cursor movement Mar 29, 2020
@anmolarora1 anmolarora1 mentioned this issue Apr 2, 2020
Merged
@raineorshine raineorshine added the hold Pause development label May 19, 2020
@raineorshine
Copy link
Contributor Author

Rendering performance is still quite still, but let's test after #188.

@raineorshine raineorshine added this to the ⚡️ 100k Thoughts milestone Jan 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hold Pause development performance Improve performance
Projects
None yet
Milestone
⚡️ 100k Thoughts
Development

No branches or pull requests
2 participants
@raineorshine @anmolarora1