Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile: Enter breaks auto-capitalization #999

Closed
raineorshine opened this issue Jan 12, 2021 · 0 comments
Closed

Mobile: Enter breaks auto-capitalization #999

raineorshine opened this issue Jan 12, 2021 · 0 comments
Labels
bug Something isn't working
Milestone
🧠 Fluid Sensemaki...

Comments

@raineorshine
Copy link
Contributor

raineorshine commented Jan 12, 2021 •
edited
Loading

Swiping does not break auto-capitalization.

Tested in Mobile Safari.

Steps to Reproduce

Ensure Auto-Capitalization is enabled in iOS Keyboard settings (default: true).

  1. Create a thought a
  2. Hit the Enter key
  3. Start typing

Current Behavior

The new thought is not capitalized.

Expected Behavior

The new thought should be capitalized.
@raineorshine raineorshine added the bug Something isn't working label Jan 12, 2021
@raineorshine raineorshine added this to the 🧠 Fluid Sensemaking milestone Jan 12, 2021
@raineorshine raineorshine mentioned this issue Mar 17, 2021
Closed
raineorshine added a commit that referenced this issue Mar 17, 2021
@raineorshine
Editable: Properly consolidate onMouseDown and onTouchEnd. Fixes #940. …
897094d 
…Fixes #960.

Regression on prevent checklist:

**Desktop:**

- [x] Set selection on click from null cursor
- [x] Set selection on cursorDown from null cursor
- [x] Set selection clicking on empty space

**Mobile:**

- [x] Enter edit mode
- [x] Preserve editing: false
- [x] Preserve editing: true
- [x] cursorBack on hidden element (#1029)
- [x] Preserve editing clicking on child edge (#946, this issue)
- [x] Preserve editing on switch app (#940)
- [x] No uncle loop (#908)
- [x] Auto-Capitalization on Enter (#999)
raineorshine added a commit that referenced this issue Dec 7, 2022
@raineorshine
useEditMode: Fix infinite loop again on nested empty thought (#999).
3d32ec0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
🧠 Fluid Sensemaking I
Development

No branches or pull requests
1 participant
@raineorshine