Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile: setCursor hangs in edit mode #908

Closed
raineorshine opened this issue Nov 14, 2020 · 1 comment
Closed

Mobile: setCursor hangs in edit mode #908

raineorshine opened this issue Nov 14, 2020 · 1 comment
Assignees
@shresthabijay
Labels
bug Something isn't working

Comments

@raineorshine
Copy link
Contributor

raineorshine commented Nov 14, 2020 •
edited
Loading

Browser: Mobile Safari

Steps to Reproduce

  • a
    • b
    • c
  1. Set the cursor on a/b
  2. Create a new sub thought a/b/d
  3. Without closing the keyboard, tap on a/c

Current Behavior

The UI locks up as if it's in an infinite loop. Eventually it halts.

Expected Behavior

Cursor should move without hanging.
@raineorshine raineorshine added the bug Something isn't working label Nov 14, 2020
@shresthabijay shresthabijay self-assigned this Nov 20, 2020
raineorshine added a commit that referenced this issue Jan 14, 2021
@raineorshine
Partially revert 0463a17 (#908). Fixes #999.
edb57d0
anmolarora1 pushed a commit to anmolarora1/em that referenced this issue Mar 10, 2021
@raineorshine
Editable: Remove unneeded setTimeout from setSelectionToCursorOffset. F…
0463a17 
…ixes cybersemics#908.
@raineorshine raineorshine mentioned this issue Mar 17, 2021
Closed
@raineorshine
Copy link
Contributor Author

raineorshine commented Mar 17, 2021 •
edited
Loading

Regression prevention checklist: #946 (comment)

raineorshine added a commit that referenced this issue Mar 17, 2021
@raineorshine
Editable: Properly consolidate onMouseDown and onTouchEnd. Fixes #940. …
897094d 
…Fixes #960.

Regression on prevent checklist:

**Desktop:**

- [x] Set selection on click from null cursor
- [x] Set selection on cursorDown from null cursor
- [x] Set selection clicking on empty space

**Mobile:**

- [x] Enter edit mode
- [x] Preserve editing: false
- [x] Preserve editing: true
- [x] cursorBack on hidden element (#1029)
- [x] Preserve editing clicking on child edge (#946, this issue)
- [x] Preserve editing on switch app (#940)
- [x] No uncle loop (#908)
- [x] Auto-Capitalization on Enter (#999)
@onurpolattimur onurpolattimur mentioned this issue Jun 13, 2021
Merged
raineorshine added a commit that referenced this issue Sep 16, 2021
@raineorshine
Remove asyncFocusThrottled since new guard prevents infinite loop (#908…
ab2969a 
…).
raineorshine added a commit that referenced this issue Sep 16, 2021
@raineorshine
Remove asyncFocusThrottled since new guard prevents infinite loop (#908…
dde60e9 
…).
raineorshine added a commit that referenced this issue Sep 17, 2021
@raineorshine
Remove asyncFocusThrottled since new guard prevents infinite loop (#908…
6acdbee 
…).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shresthabijay shresthabijay

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raineorshine @shresthabijay