This repository has been archived by the owner on Oct 8, 2020. It is now read-only.
Fix another silently failing rgeo build issue #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, passing in `--with-opt-dir` and `--with-geos-config` worked fine. After upgrading my app to Ruby 2.6 and latest bundler, options passed in through bundler don't seem to make it down to the C extension. It's worth noting also, a couple years ago, rgeo changed what the options were called, which resulted in heroku-geo-buildpack silently breaking (PR cyberdelia#34). This change puts `geos-config` and the misc build dependencies in $PATH and $CPATH/$LD_LIBRARY_PATH/$LIBRARY_PATH as appropriate, so we never have to deal with issues around passing arguments to bundler again. Additionally, if you start a heroku bash prompt, you can fuss with geos and building rgeo without learning the build options, which is nice.
|
This also happens to fix #48 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, passing in
--with-opt-dirand--with-geos-configworkedfine. After upgrading my app to Ruby 2.6 and latest bundler, options
passed in through bundler don't seem to make it down to the C extension.
It's worth noting also, a couple years ago, rgeo changed what the
options were called, which resulted in heroku-geo-buildpack silently
breaking (PR #34).
This change puts
geos-configand the misc build dependencies in$PATH and $CPATH/$LD_LIBRARY_PATH/$LIBRARY_PATH as appropriate, so we
never have to deal with issues around passing arguments to bundler
again. Additionally, if you start a heroku bash prompt, you can fuss
with geos and building rgeo without learning the build options, which is
nice.