Skip to content
This repository has been archived by the owner on Oct 8, 2020. It is now read-only.

Fix another silently failing rgeo build issue #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Jun 26, 2019

  1. Workaround for bundler?/rgeo? option passing issue

    Previously, passing in `--with-opt-dir` and `--with-geos-config` worked
    fine. After upgrading my app to Ruby 2.6 and latest bundler, options
    passed in through bundler don't seem to make it down to the C extension.
    
    It's worth noting also, a couple years ago, rgeo changed what the
    options were called, which resulted in heroku-geo-buildpack silently
    breaking (PR cyberdelia#34).
    
    This change puts `geos-config` and the misc build dependencies in
    $PATH and $CPATH/$LD_LIBRARY_PATH/$LIBRARY_PATH as appropriate, so we
    never have to deal with issues around passing arguments to bundler
    again. Additionally, if you start a heroku bash prompt, you can fuss
    with geos and building rgeo without learning the build options, which is
    nice.
    woahdae committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    7102a1e View commit details
    Browse the repository at this point in the history