New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/ci: ideas to improve the quality of CI checks #1630

Open

mvdan opened this issue Apr 13, 2022 · 1 comment

Labels

Discuss

Member

mvdan commented Apr 13, 2022

For some context, see golang/go#42119. Some low-hanging fruit that we currently do not enforce:

go vet
gofmt
go mod tidy and go mod verify
catching stale benchmarks

The text was updated successfully, but these errors were encountered:

mvdan added the Discuss label

Member Author

mvdan commented Apr 13, 2022

From https://review.gerrithub.io/c/cue-lang/cue/+/536196/1#message-4cee1770d8fd1916f3979c36d367933c949f2a76, it sounds like we should be double-checking that Signed-off-by is properly used too.

myitcv added the zGarden label

cueckoo pushed a commit that referenced this issue


          internal/ci: enforce vet and mod tidy on all modules

2ae1a9e

That is, both the root module and internal/e2e.
This would have caught our recent failures on master
due to internal/e2e not being tidied.

Updates #1630.

Signed-off-by: Daniel Martí <[email protected]>
Change-Id: Ic22d0ae16ea17d748ca16383023b2ee1a9513196
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1171769
TryBot-Result: CUEcueckoo <[email protected]>
Reviewed-by: Roger Peppe <[email protected]>
Unity-Result: CUE porcuepine <[email protected]>

mvdan removed the zGarden label

mvdan mentioned this issue

CI check for LanguageVersion with respect to tagged versions #3248

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment