Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI check for LanguageVersion with respect to tagged versions #3248

Open
rogpeppe opened this issue Jun 26, 2024 · 1 comment
Open

CI check for LanguageVersion with respect to tagged versions #3248

rogpeppe opened this issue Jun 26, 2024 · 1 comment
Labels
FeatureRequest New feature or request

Comments

@rogpeppe
Copy link
Member

If a CUE version is tagged but its cueversion.LanguageVersion is before the tag version,
it will refuse modules that have a language.version that is the same as the
tagged version, which is a bad user experience.

It would be nice to add a CI check that ensures that LanguageVersion is at least the
tagged version, but that could only apply after the tag is pushed, which we don't
have a CI process for, so such a CI check would be done too late (after
the tag has been created with the erroneous LanguageVersion).

Leaving this as an open issue so that we can think about possible safeguards.

@rogpeppe rogpeppe added the FeatureRequest New feature or request label Jun 26, 2024
@mvdan
Copy link
Member

mvdan commented Jun 26, 2024

Note #1630 as well, which is related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FeatureRequest New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants