State document updated with details on using DI #369
Conversation
|
Cheers! I'll try and pick it up soonish. Unless some one else gets to it before me. |
|
The PR is now hanging here for almost 2 weeks. Should I just merge it? |
|
I've had this on my list to review for a while. Please be patient. |
There was a problem hiding this comment.
Thank you for this addition! We really appreciate all the effort. As I'm not familiar with Guice, I can't comment on the content for Guice. (I'd have to try this out, but am not able to do so right now).
I do have some general request regarding writing style, to make it more consistent with the other docs, and easier to read.
Mainly:
- please don't use terms like "simple","simply". I understand this is probably intended to put the reader at ease ("its's not hard, you can do it!") but for someone who does not yet understand how to do something, this could be demotivating / condescending.
- Could you make the text more concise please? This includes linking to other sections for more details, where relevant (to prevent duplication of content in multiple places)
I've given some suggestions on both; please have a look and accept the ones you agree with.
Finally, if this functionality is available as of v5, let's merge after v5 has been released.
Thanks for your patience and help!
|
Enhanced readability and conciseness |
|
Much more concise, thanks! |
|
Took me a while to get around to this but it looks good to me! Thanks a bucket. |
4 participants
Cucumber 5 brings new capabilities for using an object factory. I extended the document about state with additional information on how to use Cucumber in a DI environment.