Custom object factory usage documentation #1715
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
This is really good. More then I expected. This would good content to use in the fix for: I'll see if it can be ported over. Or if you would like to have your name attached to commits you can do it but the doc pages are a bit more involved. |
|
So what is it that you recommend? Merge the PR? Or should create a new PR for that other issue? I am not sure what the process is.
… Am 02.08.2019 um 23:44 schrieb M.P. Korstanje ***@***.***>:
This is really good. More then I expected. This would be a good fix for:
cucumber/docs#362
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Ok, I had a look at the documentation project and I have no clue of where and how this could be integrated or how this relates to the mentioned issue. |
|
That is okay! I'm not sure why I closed this PR. Must have fat-fingered it. |
|
Continued in cucumber/docs#369 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A separate README.md has bee added to the core package that described the details of DI when using a custom object factory and how to do this.
(as requested in #1710)