Skip to content

Fix #207, close #195: Build problems when unit tests or examples are enabled (clang, Visual Studio) #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ghost wants to merge 2 commits into from
Closed

Fix #207, close #195: Build problems when unit tests or examples are enabled (clang, Visual Studio) #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0032338
[vs2017] warning C4265: class has virtual functions, but destructor i…
Jun 25, 2018
96d7538
Make ~BasicStep() protected non-virtual
uoqs Dec 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions include/cucumber-cpp/internal/hook/HookRegistrar.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@ class CUCUMBER_CPP_EXPORT CallableStep {

class CUCUMBER_CPP_EXPORT Hook {
public:
// [Visual Studio] [clang]
// silence false positive "warning C4265: class has virtual
// functions, but destructor is not virtual" requiring virtual destructors
// for every class that has virtual functions.
virtual ~Hook() {}

void setTags(const std::string &csvTagNotation);
virtual void invokeHook(Scenario *scenario, CallableStep *step);
virtual void skipHook();
Expand Down
8 changes: 8 additions & 0 deletions include/cucumber-cpp/internal/step/StepManager.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,13 @@ class CUCUMBER_CPP_EXPORT InvokeResult {
class CUCUMBER_CPP_EXPORT StepInfo : public boost::enable_shared_from_this<StepInfo> {
public:
StepInfo(const std::string &stepMatcher, const std::string source);

// [Visual Studio] [clang]
// silence false positive "warning C4265: class has virtual
// functions, but destructor is not virtual" requiring virtual destructors
// for every class that has virtual functions.
virtual ~StepInfo() {}

SingleStepMatch matches(const std::string &stepDescription) const;
virtual InvokeResult invokeStep(const InvokeArgs * pArgs) const = 0;

Expand All @@ -118,6 +125,7 @@ class CUCUMBER_CPP_EXPORT BasicStep {
InvokeResult invoke(const InvokeArgs *pArgs);

protected:
~BasicStep() {}
typedef const Table table_type;
typedef const Table::hashes_type table_hashes_type;

Expand Down