Fix #207, close #195: Build problems when unit tests or examples are enabled (clang, Visual Studio) #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
class BasicStep has virtual functions but no virtual destructor. If it is never deleted by pointer then its destructor can be protected non-virtual instead of public virtual. See http://www.gotw.ca/publications/mill18.htm Guideline 4 Comments are updated to mention #195 when using clang
ghost
mentioned this pull request
ghost
changed the title
ghost
requested review from
Member
|
Thanks for contribution and links. I'd rather keep #195, given that there is no real reason to prevent destruction from base pointer, so I'll close this in favour of the earlier PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding issue with clang #207 and Visual Studio #195
References:
https://stackoverflow.com/questions/43282826/
http://www.gotw.ca/publications/mill18.htm