Update Swiftlint and remove CocoaPods #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinnie4k
requested review from
JaysonHahn,
MrPeterss,
belle-hu,
caitlynjin,
cassidyxu and
daniel-chuang
caitlynjin
approved these changes
Mar 15, 2024
There is an issue with Xcode Cloud that prevented the build from archiving successfully, but I believe I already resolved it. Not sure though. |
|
I saw the earlier comment Caitlyn made and also the original PR mentioned a bug. How can I help test for this on my end? |
No need to test. Once this PR gets merged, you will just need to make changes to your Xcode project. |
This was referenced Mar 20, 2024
Closed
Merged
caitlynjin
added a commit
that referenced
this pull request
Mar 24, 2024
* Update README.md * Create pull_request_template.md * Removed building hours and replaced status * Replaced GYMS with RECREATION CENTERS in home view * Replaced capacities with FITNESS CENTER CAPACITIES * Replaced buildings hours in gym cells - Created functions for open/close time logic based on fitness centers - Changed open/close status and time * Addressed Vin's comments - Renamed home page labels - Removed `GymDetailViewModel` - Added `fitnessCenterIsOpen()` and `determineStatus()` to `Gym` model - Created test cases for the above functions - Created dummy data for Teagle - Simplified status logic in `HomeGymCell` * Fixed dummy data and removed unused code * Fixed status colors and removed unused code * Addressed Vin's comments - Fixed grammatical errors * Implemented stretchy header (#37) * Made fitness center images stretchy headers * Modified gym images as stretchy headers * Update Package.resolved * Addressed Vin's comments - Renamed geometry proxy * Addressed Vin's comments - Fixed naming error * Create Package.resolved * Tab bar styling adjustment (#38) * Made fitness center images stretchy headers * Modified gym images as stretchy headers * Adjusted font/color on tab bar and added divider * Update Package.resolved * Addressed Vin's comments - Renamed variable name * Update project.pbxproj * Update Package.resolved * Update Swiftlint and remove CocoaPods (#40) * Update Swiftlint * Fix typo * Update ci_post_clone.sh * Update ENV * Update project.pbxproj * Update Package.resolved --------- Co-authored-by: Vin Bui <[email protected]> Co-authored-by: Vin Bui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Updated Swiftlint package and removed CocoaPods.
Changes Made
Swiftlint
brew install swiftlintOther Changes
README.mdwith the new changes.ci_post_clone.shto remove CocoaPod installation and add Swiftlint installation.UpliftEnvironment.swift.Test Coverage
Next Steps
ci_post_clone.share correct. Note that there is also currently another issue regarding this that should be resolved.Screenshots
Swiftlint not installed
Swiftlint installed