Implemented stretchy header #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ui into caitlyn/issues
vinnie4k
requested changes
Feb 26, 2024
belle-hu
reviewed
Mar 3, 2024
| let height = geometryProxy.size.height | ||
|
|
||
| content | ||
| .frame(height: minY > 0 ? height + originY : height) |
There was a problem hiding this comment.
what does this logic do? I think that if some vertical delta component is non-negative, we change our height, otherwise we keep it the same. Is the purpose of this for making the header have more "range"/more animated?
There was a problem hiding this comment.
Yeah, the content in this case is the image itself, and we are adjusting the height of the image based on the view's frame relative to the whole screen. If we scroll up, the image is lower on the screen, so we increase the height of the image and the .offset modifier sets the image's y-offset so that it stays at the top of the screen. This creates an "animated stretchy" effect.
belle-hu
approved these changes
Mar 3, 2024
- Renamed geometry proxy
vinnie4k
approved these changes
Mar 7, 2024
- Fixed naming error
Merged
caitlynjin
added a commit
that referenced
this pull request
Mar 12, 2024
* Update README.md * Create pull_request_template.md * Removed building hours and replaced status * Replaced GYMS with RECREATION CENTERS in home view * Replaced capacities with FITNESS CENTER CAPACITIES * Replaced buildings hours in gym cells - Created functions for open/close time logic based on fitness centers - Changed open/close status and time * Addressed Vin's comments - Renamed home page labels - Removed `GymDetailViewModel` - Added `fitnessCenterIsOpen()` and `determineStatus()` to `Gym` model - Created test cases for the above functions - Created dummy data for Teagle - Simplified status logic in `HomeGymCell` * Fixed dummy data and removed unused code * Fixed status colors and removed unused code * Addressed Vin's comments - Fixed grammatical errors * Implemented stretchy header (#37) * Made fitness center images stretchy headers * Modified gym images as stretchy headers * Update Package.resolved * Addressed Vin's comments - Renamed geometry proxy * Addressed Vin's comments - Fixed naming error * Create Package.resolved * Tab bar styling adjustment (#38) * Made fitness center images stretchy headers * Modified gym images as stretchy headers * Adjusted font/color on tab bar and added divider * Update Package.resolved * Addressed Vin's comments - Renamed variable name * Update project.pbxproj * Update Package.resolved --------- Co-authored-by: Vin Bui <[email protected]> Co-authored-by: Vin Bui <[email protected]>
This was referenced Mar 20, 2024
Closed
Merged
caitlynjin
added a commit
that referenced
this pull request
Mar 24, 2024
* Update README.md * Create pull_request_template.md * Removed building hours and replaced status * Replaced GYMS with RECREATION CENTERS in home view * Replaced capacities with FITNESS CENTER CAPACITIES * Replaced buildings hours in gym cells - Created functions for open/close time logic based on fitness centers - Changed open/close status and time * Addressed Vin's comments - Renamed home page labels - Removed `GymDetailViewModel` - Added `fitnessCenterIsOpen()` and `determineStatus()` to `Gym` model - Created test cases for the above functions - Created dummy data for Teagle - Simplified status logic in `HomeGymCell` * Fixed dummy data and removed unused code * Fixed status colors and removed unused code * Addressed Vin's comments - Fixed grammatical errors * Implemented stretchy header (#37) * Made fitness center images stretchy headers * Modified gym images as stretchy headers * Update Package.resolved * Addressed Vin's comments - Renamed geometry proxy * Addressed Vin's comments - Fixed naming error * Create Package.resolved * Tab bar styling adjustment (#38) * Made fitness center images stretchy headers * Modified gym images as stretchy headers * Adjusted font/color on tab bar and added divider * Update Package.resolved * Addressed Vin's comments - Renamed variable name * Update project.pbxproj * Update Package.resolved * Update Swiftlint and remove CocoaPods (#40) * Update Swiftlint * Fix typo * Update ci_post_clone.sh * Update ENV * Update project.pbxproj * Update Package.resolved --------- Co-authored-by: Vin Bui <[email protected]> Co-authored-by: Vin Bui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implemented a stretchy header effect to the
GymDetailViewheader image.Changes Made
StretchyModifierview modifier that applies a stretchy effect to the header image.GymDetailViewto contain the header image in aGeometryReaderand used a geometry proxy to calculate its bounds.Related PRs or Issues
Screenshots
Stretchy Header
stretchy-header-before.mp4
stretchy-header-after.mp4