Fix formatting absolute paths#7560
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Mar 17, 2019
Merged
Conversation
RX14
added
kind:bug
asterite
reviewed
Mar 16, 2019
Member
asterite
left a comment
asterite
left a comment
There was a problem hiding this comment.
I think there's a method to check if a path is absolute
Contributor
|
Any test for this? |
Member
Author
|
There weren't any tests for this command code before, and I can't be bothered to create a whole test harness for a bugfix |
Member
Author
|
@asterite I can't find that method. |
Member
|
Sorry, my mistake, it exists in Ruby in Pathname |
straight-shoota
approved these changes
Mar 17, 2019
Member
|
#5635 adds such a method. |
sdogruyol
approved these changes
Mar 17, 2019
Member
|
Thank you @RX14 ! |
urde-graven
pushed a commit
to urde-graven/crystal
that referenced
this pull request
Mar 20, 2019
* 'master' of github.com:crystal-lang/crystal: Change the font-weight used in Playground (crystal-lang#7552) Fix formatting absolute paths (crystal-lang#7560) Refactor IO::Syscall as IO::Evented (crystal-lang#7505) YAML: fix test checking serialization of slices for libyaml 0.2.2 (crystal-lang#7555) Let Array#sort only use `<=>`, and let `<=>` return `nil` for partial comparability (crystal-lang#6611) Update `to_s` and `inspect` to have similar signatures accross the stdlib (crystal-lang#7528) Fix restriction of valid type vs free vars (crystal-lang#7536) Rewrite macro spec without executing a shell command (crystal-lang#6962) Suggest `next` when trying to break from captured block (crystal-lang#7406) Fix GenericClassType vs GenericClassInstanceType restrictions (crystal-lang#7537) Add human readable formatting for numbers (crystal-lang#6314) Add command and args to execvp error message (crystal-lang#7511) Implement Set#add? method (crystal-lang#7495)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7559