Fix: OpenSSL sockets shouldn't flush on read

src/openssl/bio.cr

@@ -41,21 +41,13 @@ struct OpenSSL::BIO
   def self.read_ex(bio, buffer, len, readp)
     count = len > Int32::MAX ? Int32::MAX : len.to_i
     io = Box(IO).unbox(LibCrypto.BIO_get_data(bio))
-
-    # FIXME: why flush (write) before reading?!
-    io.flush
-
     ret = io.read Slice.new(buffer, count)
     readp.value = LibC::SizeT.new(ret)
     1
   end
 
   def self.read(bio, buffer, len)
     io = Box(IO).unbox(LibCrypto.BIO_get_data(bio))
-
-    # FIXME: why flush (write) before reading?!
-    io.flush
-
     io.read(Slice.new(buffer, len)).to_i
   end
 
@@ -92,6 +84,14 @@ struct OpenSSL::BIO
   @boxed_io : Void*
 
   def initialize(@io : IO)
+    if io.is_a?(IO::Buffered)
+      # Disable buffers of the underlying IO (e.g. TCP socket) so OpenSSL
+      # becomes responsible of what needs to be read/written on the wire;
+      # instead, buffers shall be on OpenSSL::SSL::Socket (for example).
+      io.sync = true
+      io.read_buffering = false
+    end
+
     @bio = LibCrypto.BIO_new(CRYSTAL_BIO)
 
     # We need to store a reference to the box because it's

src/openssl/ssl/socket.cr

@@ -101,13 +101,6 @@ abstract class OpenSSL::SSL::Socket < IO
       raise OpenSSL::Error.new("SSL_new")
     end
 
-    # Since OpenSSL::SSL::Socket is buffered it makes no
-    # sense to wrap a IO::Buffered with buffering activated.
-    if io.is_a?(IO::Buffered)
-      io.sync = true
-      io.read_buffering = false
-    end
-
     @bio = BIO.new(io)
     LibSSL.ssl_set_bio(@ssl, @bio, @bio)
   end