Fix: OpenSSL sockets shouldn't flush on read#16650
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Feb 12, 2026
Merged
Fix: OpenSSL sockets shouldn't flush on read#16650straight-shoota merged 2 commits intocrystal-lang:masterfrom
straight-shoota merged 2 commits intocrystal-lang:masterfrom
Conversation
ysbaddaden
added
kind:bug
straight-shoota
approved these changes
Feb 10, 2026
ysbaddaden
added a commit
to ysbaddaden/crystal
that referenced
this pull request
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #16640 (comment)
There's no reason for reading from the socket to autoflush the write buffer of the underlying IO object (e.g. TCP socket), especially since we already disable the buffers in
OpenSSL::SSL::Socket#initialize, so it ends up being a NOOP in practice.Crystal::BIO#initializenow always disables the buffers, so the logic is grouped together, instead of havingOpenSSL::SSL::Socketdo it.NOTE: this is potentially a breaking change if someone re-enabled buffers or expects the buffers to be buffered (in non SSL socket situations).