Skip to content

Fix: memory leak in XML::Document#finalize #16418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
straight-shoota merged 1 commit into from
Nov 27, 2025
Merged

Fix: memory leak in XML::Document#finalize #16418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/xml/document.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class XML::Document < XML::Node
def finalize
# free unlinked nodes and their subtrees
@unlinked_nodes.each do |node|
if node.value.doc == @node
if node.value.doc.as(LibXML::Node*) == @node
LibXML.xmlFreeNode(node)
else
# the node has been adopted into another document, don't free!
Expand Down