Fix: memory leak in XML::Document#finalize#16418
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Nov 27, 2025
Merged
Fix: memory leak in XML::Document#finalize#16418straight-shoota merged 1 commit intocrystal-lang:masterfrom
XML::Document#finalize#16418straight-shoota merged 1 commit intocrystal-lang:masterfrom
Conversation
straight-shoota
added
kind:bug
ysbaddaden
approved these changes
Nov 25, 2025
ysbaddaden
changed the title
LibXML::Doc* to LibXML::Node*XML::Document#finalize
cyangle
approved these changes
Nov 26, 2025
toddsundsted
added a commit
to toddsundsted/ktistec
that referenced
this pull request
Feb 24, 2026
Reverts 85a60cd. Requires Crystal version >= 1.19.1. See: - crystal-lang/crystal#16414 - crystal-lang/crystal#16418 - crystal-lang/crystal#16419 - crystal-lang/crystal#16432
toddsundsted
added a commit
to toddsundsted/ktistec
that referenced
this pull request
Mar 1, 2026
Reverts 85a60cd. Requires Crystal version >= 1.19.1. See: - crystal-lang/crystal#16414 - crystal-lang/crystal#16418 - crystal-lang/crystal#16419 - crystal-lang/crystal#16432
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-opens #16412