Skip to content

Use native UInt128 in Dragonbox#16262

Draft
HertzDevil wants to merge 1 commit intocrystal-lang:masterfrom
HertzDevil:refactor/dragonbox-uint128
Draft

Use native UInt128 in Dragonbox#16262
HertzDevil wants to merge 1 commit intocrystal-lang:masterfrom
HertzDevil:refactor/dragonbox-uint128

Conversation

@HertzDevil
Copy link
Contributor

This allows CACHE to be defined in a slice literal eventually.

@straight-shoota straight-shoota added this to the 1.19.0 milestone Oct 24, 2025
@straight-shoota
Copy link
Member

This seems to be breaking compatibility with Crystal <= 1.2
https://github.com/crystal-lang/crystal/actions/runs/18777089311/job/53592899456

The error message is not very telling: Error: while requiring "prelude". But 128-bit literals were only introduced in Crystal 1.3.
So we can't use them here while keeping forward compatibility down to 1.0 (related: #12937).

@straight-shoota straight-shoota removed this from the 1.19.0 milestone Oct 24, 2025
@HertzDevil HertzDevil marked this pull request as draft October 24, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants