Bump minimum required compiler to be 1.2.0#12937
Open
beta-ziliani wants to merge 7 commits intocrystal-lang:masterfrom
Open
Bump minimum required compiler to be 1.2.0#12937beta-ziliani wants to merge 7 commits intocrystal-lang:masterfrom
beta-ziliani wants to merge 7 commits intocrystal-lang:masterfrom
Conversation
Contributor
|
We should remove 1.0 and 1.1 from CI immediately, right? |
HertzDevil
added
topic:infrastructure
breaking-change
Sija
reviewed
Jan 11, 2023
Contributor
|
The AArch64 Docker images are still using 1.0.0 |
Member
Author
|
@HertzDevil great opportunity to see the check installed in action a40e660 |
Collaborator
|
Another use-case for bumping the minimal compiler version appeared in #16034 that needs support for annotations on method arguments (in the parser at least) that was only introduced in 1.5.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps the minimum required compiler to be 1.2.0. This allow us to use features included in 1.1, like Int128 literals, enabling #11944 #5545 and avoiding hacks like this.
It's still missing a mechanism to make visible the minimum required version. That will come with another PR.