Move *::Serializable's private constructors into macro included hook#16147
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Sep 10, 2025
Merged
Conversation
HertzDevil
added
kind:bug
straight-shoota
approved these changes
Sep 8, 2025
mverzilli
approved these changes
Sep 9, 2025
Contributor
|
This might have caused some regression? See:
Seems like it's resolving |
Contributor
Author
|
Yeah the converter expression is now resolved in the includer's scope rather than Personally I'd argue that using |
akadusei
added a commit
to GrottoPress/mel
that referenced
this pull request
Oct 28, 2025
```
Which expanded to:
> 18 | **job_args
> 19 | ) : String?
> 20 | job = new(**job_args)
^--
Error: no overload matches 'CollectJobsJob.new' with type
Overloads are:
- CollectJobsJob.new(pull : ::JSON::PullParser)
- CollectJobsJob.new(*, __pull_for_json_serializable pull : ::JSON::PullParser)
```
This is likely due to <crystal-lang/crystal#16147>.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16140.
As a bonus, it is now possible to refer to generic type variables inside converters (see #16142 (comment) for an example).