Fixes regression in Object.from_json [fixup #15840]#16142
Merged
straight-shoota merged 4 commits intocrystal-lang:masterfrom Sep 18, 2025
Merged
Fixes regression in Object.from_json [fixup #15840]#16142straight-shoota merged 4 commits intocrystal-lang:masterfrom
Object.from_json [fixup #15840]#16142straight-shoota merged 4 commits intocrystal-lang:masterfrom
Conversation
Sija
force-pushed
the
fix-issue-16141
branch
from
aa8d936 to
63266f5
Compare
mverzilli
reviewed
Sep 7, 2025
mverzilli
approved these changes
Sep 7, 2025
Sija
force-pushed
the
fix-issue-16141
branch
from
63266f5 to
3bb1cef
Compare
Sija
force-pushed
the
fix-issue-16141
branch
from
3bb1cef to
e49492a
Compare
HertzDevil
added
topic:stdlib:serialization
kind:regression
Member
|
Going with #16142 (comment) I'd suggest to just remove this type restriction. There's reasonable doubt that it's a good change, so we should revert it for now. These PRs adding type restrictions are usually very straightforward, but in this case it is not. If we want to change this, we should put in more thoughtful consideration. |
ysbaddaden
changed the title
Object.from_jsonObject.from_json [fixup #15840]
straight-shoota
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #16141