Skip to content

Fix HTTP::Request#query= typing#16143

Merged
Blacksmoke16 merged 1 commit intomasterfrom
request-query-setter-typing
Sep 8, 2025
Merged

Fix HTTP::Request#query= typing#16143
Blacksmoke16 merged 1 commit intomasterfrom
request-query-setter-typing

Conversation

@Blacksmoke16
Copy link
Member

@Blacksmoke16 Blacksmoke16 commented Sep 7, 2025

It internally calls URI#query= which accepts nil so having HTTP::Request be String was overly restrictive.

Follow up to #15710.

@Blacksmoke16 Blacksmoke16 added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:networking labels Sep 7, 2025
@straight-shoota straight-shoota added this to the 1.18.0 milestone Sep 8, 2025
@Blacksmoke16 Blacksmoke16 merged commit fdbe446 into master Sep 8, 2025
80 checks passed
@Blacksmoke16 Blacksmoke16 deleted the request-query-setter-typing branch December 5, 2025 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:networking

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants