Add type restrictions to http#15710
Merged
straight-shoota merged 6 commits intocrystal-lang:masterfrom Sep 6, 2025
Merged
Conversation
Sija
reviewed
May 5, 2025
straight-shoota
approved these changes
Aug 9, 2025
mverzilli
approved these changes
Sep 4, 2025
Blacksmoke16
reviewed
Sep 7, 2025
|
|
||
| # Sets request's query component. | ||
| def query=(value) | ||
| def query=(value : String) : String |
Member
There was a problem hiding this comment.
This one caused a regression in Athena since before you could pass nil as per https://crystal-lang.org/api/URI.html#query%3D%28query%3AString%7CNil%29-instance-method
straight-shoota
added a commit
that referenced
this pull request
Feb 1, 2026
Fixes a regression from 1.18 (#15710). That change added type restrictions to `Headers[]=` which should've caused a type error in `Headers#merge!`, but this was shadowed by unexpected behaviour from `forward_missing_to`. The error condition was not triggered in specs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the output of compiling cr-source-typer and running it with the below incantation:
CRYSTAL_PATH="./src" ./typer spec/std_spec.cr
--error-trace --exclude src/crystal/
--stats --progress
--union-size-threshold 2
--ignore-private-defs
--ignore-protected-defs
src/http
This is related to #15682 .
I also reran the above command but without the --union-size-threshold 2, and updated several long union types to a common base class (typically IO).