Add file name to file-private virtual types during codegen#15897
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Jun 15, 2025
Merged
Conversation
HertzDevil
added
kind:bug
straight-shoota
approved these changes
Jun 13, 2025
ysbaddaden
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is exactly like #15505, but for
Crystal::VirtualTypeandVirtualMetaclassType. Also ensures the~match<...>internal functions use these file names for proper dynamic dispatch. This discovery led to this fixup in #15896.Of the remaining internal types,
GenericInstanceType,GenericClassInstanceMetaclassType, andGenericModuleInstanceMetaclassTypecallType#to_sdirectly inside their#to_s_with_optionsoverloads, without forwarding thecodegenparameter. Most likely they are also broken in some way.