Add file name to file-private metaclass types during codegen [fixup #15485]#15505
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Feb 23, 2025
Merged
Conversation
HertzDevil
added
kind:bug
straight-shoota
approved these changes
Feb 22, 2025
ysbaddaden
approved these changes
Feb 22, 2025
straight-shoota
changed the title
1 task
straight-shoota
pushed a commit
that referenced
this pull request
Jun 15, 2025
This is exactly like #15505, but for `Crystal::VirtualType` and `VirtualMetaclassType`. Also ensures the `~match<...>` internal functions use these file names for proper dynamic dispatch. Of the remaining internal types, `GenericInstanceType`, `GenericClassInstanceMetaclassType`, and `GenericModuleInstanceMetaclassType` call `Type#to_s` directly inside their `#to_s_with_options` overloads, without forwarding the `codegen` parameter. Most likely, they are also broken in some way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15503.
(Apparently if you don't pass a
filenameargument torunin the codegen spec, then all the file-private types will be placed under the top-level namespace instead...?)