Fix interpreter guard clauses for signal handling#15892
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Jun 16, 2025
Merged
Fix interpreter guard clauses for signal handling#15892straight-shoota merged 2 commits intocrystal-lang:masterfrom
straight-shoota merged 2 commits intocrystal-lang:masterfrom
Conversation
straight-shoota
added
kind:bug
Collaborator
|
To be honest I don't understand why we need to support previous compiler releases for the interpreter: it's unreleased, unstable, and it can't be forward compatible anyway. |
ysbaddaden
approved these changes
Jun 11, 2025
Member
Author
|
We should support at least the latest stable release. That was the problem after merging #12241: In order to use the current standard library, you needed a build of the interpreter from master with that patch. It wouldn't work with 1.14. And that's annoying when you're working on the standard library itself. |
Member
Author
|
CI seems to be stuck 😢 |
ysbaddaden
approved these changes
Jun 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guard clauses introduced in #15178 to protect using the API for #14766 are wrong. The guards check for instance methods, which are never defined because we're using class methods instead.
As a result, the fix for #12241 was never actually applied.
The spec file uses the same guard clause, so it didn't run.
This was discovered by @jneen in https://discord.com/channels/591460182777790474/591597160492171264/1382014668784275457