Add compiler versions constraints for interpreter signal handler [fixup #14766]#15178
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Nov 13, 2024
Conversation
straight-shoota
added
kind:bug
straight-shoota
force-pushed
the
fix/interpreter-forward-compatibility
branch
from
4fb9ad0 to
ad01192
Compare
straight-shoota
force-pushed
the
fix/interpreter-forward-compatibility
branch
from
e6ba3a2 to
a4ef8b0
Compare
ysbaddaden
approved these changes
Nov 12, 2024
straight-shoota
changed the title
1 task
This was referenced Jun 11, 2025
straight-shoota
added a commit
that referenced
this pull request
Jun 16, 2025
The guard clauses introduced in #15178 to protect using the API for #14766 are wrong. The guards check for instance methods, which are never defined because we're using class methods instead. As a result, the fix for #12241 was never actually applied. The spec file uses the same guard clause, so it didn't run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #14766. The new primitives are only available in master
This patch ensures forward compatibility for the latest stable compiler (Crystal 1.14) and below.
It would be useful to have a macro that checks for the availability of primitives.