Add __crystal_raise_cast_failed for non-interpreted code#15708
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Apr 27, 2025
Merged
Conversation
straight-shoota
approved these changes
Apr 25, 2025
ysbaddaden
approved these changes
Apr 25, 2025
Collaborator
ysbaddaden
left a comment
ysbaddaden
left a comment
There was a problem hiding this comment.
Such a lovely fix. One less codegen calls into semantics ❤️
Collaborator
|
Successfully created backport PR for |
Collaborator
|
I'm wondering if we could go one step further and move the expansion to the semantics pass, where it would belong better? Codegen would then merely generate, or interpret, whatever it's told to, and the LLVM codegen wouldn't need to map type ids to class names. |
straight-shoota
added a commit
that referenced
this pull request
Apr 28, 2025
…15712) Co-authored-by: Quinton Miller <nicetas.c@gmail.com> Co-authored-by: Johannes Müller <straightshoota@gmail.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #15705.
This completely circumvents the slow
MainVisitorinvocation per compiler-generatedraise(TypeCastError.new(...))call by reimplementing the raise using a top-level fun plus LLVM instructions. It also partially addresses the issue where the codegen phase could theoretically instantiate new types due to the use of aMainVisitor(the only remaining place is#cant_pass_closure_to_c_exception_call).There is now an internal
~type_id_to_class_namefunction that returns the type name corresponding to a given instance type ID. It works even whenClass#nameis not implemented in the standard library. This might be useful for other purposes such as debugger tooling.