Workaround for #15705: slow compilation of Crystal.bufferer_message#15707
Closed
ysbaddaden wants to merge 1 commit intocrystal-lang:masterfrom
Closed
Workaround for #15705: slow compilation of Crystal.bufferer_message#15707ysbaddaden wants to merge 1 commit intocrystal-lang:masterfrom
Crystal.bufferer_message#15707ysbaddaden wants to merge 1 commit intocrystal-lang:masterfrom
Conversation
…rer_message` Inlines the inspect of exceptions into the `Crystal.buffered_message` method to avoid call(s) to `Exception#inspect_with_backtrace(IO)` that causes a dramatic impact on performance when compiling the crystal compiler (and potentially other applications).
ysbaddaden
added
the
kind:regression
Collaborator
Author
|
Apparently @HertzDevil just fixed it 🙇 |
ysbaddaden
removed
the
kind:regression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inlines the inspect of exceptions into the
Crystal.buffered_messagemethod to avoid call(s) toException#inspect_with_backtrace(IO)that causes a dramatic impact on performance when compiling the crystal compiler (and potentially other applications).Labeled as regression because
Fiber.runcallsCrystal.print_bufferedthat might also exhibit the same issue outside of execution contexts.Workaround for #15705.