Unroll test data in specs for crypto/subtle#15702
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Apr 30, 2025
Merged
Unroll test data in specs for crypto/subtle#15702straight-shoota merged 1 commit intocrystal-lang:masterfrom
crypto/subtle#15702straight-shoota merged 1 commit intocrystal-lang:masterfrom
Conversation
ysbaddaden
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test setup for
constant_time_byte_eqis broken because types the parameters asInt32 | UInt8, but the method should only acceptUInt8(ref #15694 (comment)).Removing the data hash makes the test clean and slick. It's easier to understand what's going on.
Did the same for
constant_time_compare, even though there's no technical reason there.