Add type restrictions to crypto directory#15694
Merged
straight-shoota merged 8 commits intocrystal-lang:masterfrom Aug 7, 2025
Merged
Add type restrictions to crypto directory#15694straight-shoota merged 8 commits intocrystal-lang:masterfrom
straight-shoota merged 8 commits intocrystal-lang:masterfrom
Conversation
yxhuvud
reviewed
Apr 23, 2025
Vici37
commented
Apr 24, 2025
straight-shoota
added a commit
that referenced
this pull request
Apr 30, 2025
The test setup for `constant_time_byte_eq` is broken because types the parameters as `Int32 | UInt8`, but the method should only accept `UInt8` (ref #15694 (comment)). Removing the data hash makes the test clean and slick. It's easier to understand what's going on. For `constant_time_compare` there's no technical reason, but it still improves code quality.
…-to-crypto' into add-type-restrictions-to-crypto
straight-shoota
approved these changes
May 2, 2025
ysbaddaden
approved these changes
Aug 5, 2025
Sija
reviewed
Aug 5, 2025
Co-authored-by: Sijawusz Pur Rahnama <sija@sija.pl>
straight-shoota
approved these changes
Aug 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the output of compiling cr-source-typer and running it with the below incantation:
This is related to #15682 .