Skip to content

Remove top-level calls to LibGC.has_method? for backwards compat #15635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
straight-shoota merged 1 commit into from
Apr 7, 2025
Merged

Remove top-level calls to LibGC.has_method? for backwards compat #15635

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions src/gc/boehm.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,21 +431,21 @@ module GC
sb.mem_base = stack_bottom
LibGC.set_stackbottom(thread_handle, pointerof(sb))
end
{% elsif LibGC.has_method?(:set_stackbottom) %}
# this is necessary because Boehm GC does _not_ use `GC_stackbottom` on
# Windows when pushing all threads' stacks; it also started crashing on
# Linux with libgc after v8.2.4; instead `GC_set_stackbottom` must be used
# to associate the new bottom with the running thread
def self.set_stackbottom(stack_bottom : Void*)
sb = LibGC::StackBase.new
sb.mem_base = stack_bottom
# `nil` represents the current thread (i.e. the only one)
LibGC.set_stackbottom(nil, pointerof(sb))
end
{% else %}
# support for legacy gc releases
def self.set_stackbottom(stack_bottom : Void*)
LibGC.stackbottom = stack_bottom
\{% if LibGC.has_method?(:set_stackbottom) %}
# this is necessary because Boehm GC does _not_ use `GC_stackbottom` on
# Windows when pushing all threads' stacks; it also started crashing on
# Linux with libgc after v8.2.4; instead `GC_set_stackbottom` must be used
# to associate the new bottom with the running thread
sb = LibGC::StackBase.new
sb.mem_base = stack_bottom
# `nil` represents the current thread (i.e. the only one)
LibGC.set_stackbottom(nil, pointerof(sb))
\{% else %}
# support for legacy gc releases
LibGC.stackbottom = stack_bottom
\{% end %}
end
{% end %}

Expand Down