Remove top-level calls to LibGC.has_method? for backwards compat#15635
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Apr 7, 2025
Merged
Conversation
straight-shoota
added
kind:bug
mverzilli
approved these changes
Apr 4, 2025
ysbaddaden
approved these changes
Apr 4, 2025
straight-shoota
changed the title
LibGC.has_method? for backwards compatLibGC.has_method? for backwards compat
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
has_method?in top-level macro expressions was broken before Crystal 1.7.0 (fixed in #12848).On older compiler versions
LibGC.has_method?(:set_stackbottom)would always returnfalseand break assumptions about available lib symbols.This patch simply moves the macro expression into the
defbody. We don't need this on the top level.More details in #15633 (comment)
Resolves #15633