Fix location of MacroExpression nodes#15524
Merged
straight-shoota merged 2 commits intocrystal-lang:masterfrom Feb 27, 2025
Merged
Fix location of MacroExpression nodes#15524straight-shoota merged 2 commits intocrystal-lang:masterfrom
MacroExpression nodes#15524straight-shoota merged 2 commits intocrystal-lang:masterfrom
Conversation
straight-shoota
approved these changes
Feb 25, 2025
nobodywasishere
approved these changes
Feb 26, 2025
ysbaddaden
approved these changes
Feb 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes incorrect location of
MacroExpressionnodes, due to the fact that:@token.locationwas being called too late, sinceparse_macro_expressionwas advancing the position before the assignmenttoken_end_locationwas being called too earlyBefore this PR:
after: