Skip to content

Add Lint/WhitespaceAroundMacroExpression rule#583

Merged
Sija merged 4 commits intomasterfrom
whitespace-around-macro-expression-rule
Oct 22, 2025
Merged

Add Lint/WhitespaceAroundMacroExpression rule#583
Sija merged 4 commits intomasterfrom
whitespace-around-macro-expression-rule

Conversation

@Sija
Copy link
Member

@Sija Sija commented Feb 26, 2025

Depends on crystal-lang/crystal#15524

Warning

Requires Crystal 1.16.0

@Sija Sija added the rule label Feb 26, 2025
@Sija Sija added this to the 1.7.0 milestone Feb 26, 2025
@Sija Sija requested a review from veelenga February 26, 2025 01:09
@Sija Sija self-assigned this Feb 26, 2025
@Sija Sija marked this pull request as ready for review October 21, 2025 00:58
@Sija Sija enabled auto-merge October 21, 2025 01:13
@Sija Sija force-pushed the whitespace-around-macro-expression-rule branch 2 times, most recently from 9d72a79 to 51d197d Compare October 22, 2025 22:54
@Sija Sija force-pushed the whitespace-around-macro-expression-rule branch from 51d197d to c64a2a2 Compare October 22, 2025 23:00
@Sija Sija requested a review from nobodywasishere October 22, 2025 23:01
@Sija Sija force-pushed the whitespace-around-macro-expression-rule branch from c64a2a2 to b8ec0d0 Compare October 22, 2025 23:03
@Sija Sija merged commit b11d3b4 into master Oct 22, 2025
4 checks passed
@Sija Sija deleted the whitespace-around-macro-expression-rule branch October 22, 2025 23:07
@Sija
Copy link
Member Author

Sija commented Oct 23, 2025

Hmm, for some reason, it's not working in all of the cases. See the Crystal repo as an example - there's plenty of macro expressions that should be flagged, yet they're not... 🤔

@Sija Sija added the crystal version dependent Requires a specific version of Crystal label Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crystal version dependent Requires a specific version of Crystal rule

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants