Make Crystal::IOCP::OverlappedOperation abstract#14987
Merged
straight-shoota merged 3 commits intocrystal-lang:masterfrom Sep 9, 2024
Merged
Make Crystal::IOCP::OverlappedOperation abstract#14987straight-shoota merged 3 commits intocrystal-lang:masterfrom
Crystal::IOCP::OverlappedOperation abstract#14987straight-shoota merged 3 commits intocrystal-lang:masterfrom
Conversation
HertzDevil
added
topic:stdlib:concurrency
kind:refactor
platform:windows
Member
straight-shoota
left a comment
straight-shoota
left a comment
There was a problem hiding this comment.
This looks like a good idea 👍
The duplication of #try_cancel is a bit unfortunate, because the code structure is pretty similar (also similar for DNS from #14979). Maybe we could find a way to abstract this in a meaningful way, but it's fine. It's mostly boilerplate anyway.
I suppose #try_cancel should be declared as an abstract def in OverlappedOperation though.
straight-shoota
approved these changes
Sep 7, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows different overlapped operations to provide their own closure data, instead of putting everything in one big class, such as in #14979 (comment).