Async DNS resolution on Windows#14979
Merged
straight-shoota merged 4 commits intocrystal-lang:masterfrom Sep 13, 2024
Merged
Conversation
Member
straight-shoota
left a comment
There was a problem hiding this comment.
issue: GetAddrInfoExW only supports overlapped operations since Windows 8. Crystal technically supports down to Windows 7, although only with a flag (-Dwin7).
If we want to continue support for Windows 7, we would need to keep the getaddrinfo implementation or add a non-overlapped implementation for GetAddrInfoExW.
Sija
reviewed
Sep 6, 2024
Comment on lines
66
to
76
| if result == 0 | ||
| return addrinfos | ||
| else | ||
| case error = WinError.new(result.to_u32!) | ||
| when .wsa_io_pending? | ||
| # used in `Crystal::IOCP::OverlappedOperation#try_cancel_getaddrinfo` | ||
| operation.handle = cancel_handle | ||
| else | ||
| raise ::Socket::Addrinfo::Error.from_os_error("GetAddrInfoExW", error, domain: domain, type: type, protocol: protocol, service: service) | ||
| end | ||
| end |
Contributor
There was a problem hiding this comment.
Could be simplified:
Suggested change
| if result == 0 | |
| return addrinfos | |
| else | |
| case error = WinError.new(result.to_u32!) | |
| when .wsa_io_pending? | |
| # used in `Crystal::IOCP::OverlappedOperation#try_cancel_getaddrinfo` | |
| operation.handle = cancel_handle | |
| else | |
| raise ::Socket::Addrinfo::Error.from_os_error("GetAddrInfoExW", error, domain: domain, type: type, protocol: protocol, service: service) | |
| end | |
| end | |
| return addrinfos if result.zero? | |
| case error = WinError.new(result.to_u32!) | |
| when .wsa_io_pending? | |
| # used in `Crystal::IOCP::OverlappedOperation#try_cancel_getaddrinfo` | |
| operation.handle = cancel_handle | |
| else | |
| raise ::Socket::Addrinfo::Error.from_os_error("GetAddrInfoExW", error, domain: domain, type: type, protocol: protocol, service: service) | |
| end |
straight-shoota
pushed a commit
that referenced
this pull request
Sep 9, 2024
This allows different overlapped operations to provide their own closure data, instead of putting everything in one big class, such as in #14979 (comment).
straight-shoota
approved these changes
Sep 10, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves part of #13619.
Here is a very brief benchmark:
Without this PR: