Deprecate ::sleep(Number)#14962
Merged
straight-shoota merged 1 commit intocrystal-lang:masterfrom Sep 5, 2024
Merged
Conversation
straight-shoota
approved these changes
Sep 3, 2024
1 task
lachlan
added a commit
to lachlan/crystal-tds
that referenced
this pull request
Oct 11, 2024
Compiling the TDS driver with Crystal v1.14.0 results in the
following warning:
C:\crystal-tds>crystal spec
In spec\spec_helper.cr:16:7
16 | sleep(5)
^----
Warning: Deprecated ::sleep. Use `::sleep(Time::Span)` instead
A total of 1 warnings were found.
The `sleep(Number)` method has been deprecated in Crystal v1.14.0,
refer: crystal-lang/crystal#14962.
This fix changes the use of `sleep(Number)` to `sleep(Time::Span)`
in the `spec_helper.cr` file.
lachlan
added a commit
to lachlan/crystal-tds
that referenced
this pull request
Oct 11, 2024
Compiling the TDS driver with Crystal v1.14.0 results in the
following warning:
C:\crystal-tds>crystal spec
In spec\spec_helper.cr:16:7
16 | sleep(5)
^----
Warning: Deprecated ::sleep. Use `::sleep(Time::Span)` instead
A total of 1 warnings were found.
The `sleep(Number)` method has been deprecated in Crystal v1.14.0,
refer: crystal-lang/crystal#14962.
This fix changes the use of `sleep(Number)` to `sleep(Time::Span)`
in the `spec_helper.cr` file.
Collaborator
|
This pull request has been mentioned on Crystal Forum. There might be relevant details there: https://forum.crystal-lang.org/t/how-to-do-rand-0-2-0-5-after-deprecated-sleep/7299/2 |
wonderix
pushed a commit
to wonderix/crystal-tds
that referenced
this pull request
Oct 14, 2024
Compiling the TDS driver with Crystal v1.14.0 results in the
following warning:
C:\crystal-tds>crystal spec
In spec\spec_helper.cr:16:7
16 | sleep(5)
^----
Warning: Deprecated ::sleep. Use `::sleep(Time::Span)` instead
A total of 1 warnings were found.
The `sleep(Number)` method has been deprecated in Crystal v1.14.0,
refer: crystal-lang/crystal#14962.
This fix changes the use of `sleep(Number)` to `sleep(Time::Span)`
in the `spec_helper.cr` file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in line with other places in the standard library that favor
Time::Spanover number types, such as #14368 and #14805.