Pass Time::Span to sleep (to please upcoming deprecation)#784
Merged
Conversation
spuun
requested review from
carlhoerberg,
kickster97,
snichme and
viktorerlingsson
as code owners
kickster97
approved these changes
Sep 16, 2024
Member
kickster97
left a comment
kickster97
left a comment
There was a problem hiding this comment.
the threshold is low to change to milliseconds now that you already have a PR so i would vote for doing it right the first time, but still approve :)
carlhoerberg
approved these changes
Sep 16, 2024
Member
|
I'm too late, but saw some small inconsistencies. Fixed it here! 20c21d7 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT is this pull request doing?
sleep(Number)is deprecated in crystal 1.14, see crystal-lang/crystal#14962This will make sure we pass
Time::Spaneverywhere.HOW can this pull request be tested?
Runs specs